[Intel-xe] [PATCH v7 3/3] fault-inject: Include linux/types.h by default.

Nilawar, Badal badal.nilawar at intel.com
Tue Jul 25 15:30:24 UTC 2023


Hi Himal,

On 25-07-2023 20:39, Himal Prasad Ghimiray wrote:
> Functions should_fail_alloc_page, should_failslab, and __should_failslab
> are declared irrespective of CONFIG_FAULT_INJECTION. These functions use
> bool and gfp_t types, which are treated as unknown when CONFIG_FAULT_INJECTION
> is disabled because the inclusion of linux/types.h is missing.
> 
Add fixes tag.
Fixes: 6ff1cb355e62 ("[PATCH] fault-injection capabilities infrastructure")
> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> Cc: Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
Cc: or Reviewed-by: ?

Regards,
Badal Nilawar
> Cc: Badal Nilawar <badal.nilawar at intel.com>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
> ---
>   include/linux/fault-inject.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/fault-inject.h b/include/linux/fault-inject.h
> index 481abf530b3c..f83ab2b6cd08 100644
> --- a/include/linux/fault-inject.h
> +++ b/include/linux/fault-inject.h
> @@ -2,9 +2,10 @@
>   #ifndef _LINUX_FAULT_INJECT_H
>   #define _LINUX_FAULT_INJECT_H
>   
> +#include <linux/types.h>
> +
>   #ifdef CONFIG_FAULT_INJECTION
>   
> -#include <linux/types.h>
>   #include <linux/debugfs.h>
>   #include <linux/configfs.h>
>   #include <linux/ratelimit.h>


More information about the Intel-xe mailing list