[Intel-xe] [PATCH v2 03/10] drm/xe: Fix checking for unset value

[Matt Roper]

On Wed, Jul 26, 2023 at 09:07:01AM -0700, Lucas De Marchi wrote:
> Commit 0f885eced0a8 ("drm/xe: NULL binding implementation") introduced
> the NULL binding implementation, but left a case in which the out value
> is_vram is not set and the caller will use whatever was on stack.
> Eventually the is_vram out could be removed, but this should at least
> fix the current bug.
> 
> Fixes: 0f885eced0a8 ("drm/xe: NULL binding implementation")
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_pt.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
> index d4660520ac2c..d5a237b7c883 100644
> --- a/drivers/gpu/drm/xe/xe_pt.c
> +++ b/drivers/gpu/drm/xe/xe_pt.c
> @@ -81,8 +81,10 @@ u64 xe_pde_encode(struct xe_bo *bo, u64 bo_offset,
>  static dma_addr_t vma_addr(struct xe_vma *vma, u64 offset,
>  			   size_t page_size, bool *is_vram)
>  {
> -	if (xe_vma_is_null(vma))
> +	if (xe_vma_is_null(vma)) {
> +		*is_vram = 0;
>  		return 0;
> +	}
>  
>  	if (xe_vma_is_userptr(vma)) {
>  		struct xe_res_cursor cur;
> -- 
> 2.40.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation