[Intel-xe] [PATCH] drm/xe: Signal out-syncs on VM binds if no operations
Rodrigo Vivi
rodrigo.vivi at intel.com
Wed Jul 26 18:57:59 UTC 2023
On Wed, Jul 26, 2023 at 09:46:24AM -0700, Matthew Brost wrote:
> If no operations are generated for VM binds the out-syncs must still be
> signaled.
>
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 6429d6e5113d..ddb1b4af6458 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -3374,6 +3374,8 @@ int xe_vm_bind_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
> unwind_ops:
> vm_bind_ioctl_ops_unwind(vm, ops, args->num_binds);
> free_syncs:
> + for (i = 0; err == -ENODATA && i < num_syncs; i++)
> + xe_sync_entry_signal(&syncs[i], NULL, dma_fence_get_stub());
after offline chat and after carefully checking all the possible
cases where err == -ENODATA,
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> while (num_syncs--)
> xe_sync_entry_cleanup(&syncs[num_syncs]);
>
> --
> 2.34.1
>
More information about the Intel-xe
mailing list