[Intel-xe] [PATCH v2 0/3] Remove use of BUG_ON

Francois Dugast francois.dugast at intel.com
Thu Jul 27 13:26:27 UTC 2023


After offline discussions and feedback on the first series, taking a step back
here and only address the issue of misusing BUG_ON() in situations where it is
not needed.
Proper error handling with recovery code and switching to drm_err* require case
by case analysis and fix, so this will be done in another series.

Francois Dugast (3):
  drm/xe/macro: Remove unused constant
  drm/xe: Prefer WARN() over BUG() to avoid crashing the kernel
  drm/xe/macro: Display XE_WARN_ON messages only in debug mode

 drivers/gpu/drm/i915/display/intel_display.c |  2 +-
 drivers/gpu/drm/xe/xe_bb.c                   |  8 +--
 drivers/gpu/drm/xe/xe_bo.c                   | 52 +++++++++---------
 drivers/gpu/drm/xe/xe_bo.h                   | 14 ++---
 drivers/gpu/drm/xe/xe_bo_evict.c             |  4 +-
 drivers/gpu/drm/xe/xe_execlist.c             | 14 ++---
 drivers/gpu/drm/xe/xe_force_wake.c           |  4 +-
 drivers/gpu/drm/xe/xe_force_wake.h           |  4 +-
 drivers/gpu/drm/xe/xe_ggtt.c                 | 12 ++---
 drivers/gpu/drm/xe/xe_gt_clock.c             |  4 +-
 drivers/gpu/drm/xe/xe_gt_debugfs.c           |  2 +-
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c  | 12 ++---
 drivers/gpu/drm/xe/xe_guc.c                  | 22 ++++----
 drivers/gpu/drm/xe/xe_guc_ads.c              | 14 ++---
 drivers/gpu/drm/xe/xe_guc_ct.c               | 22 ++++----
 drivers/gpu/drm/xe/xe_guc_hwconfig.c         |  2 +-
 drivers/gpu/drm/xe/xe_guc_log.c              |  4 +-
 drivers/gpu/drm/xe/xe_guc_submit.c           | 48 ++++++++---------
 drivers/gpu/drm/xe/xe_huc.c                  |  2 +-
 drivers/gpu/drm/xe/xe_hw_engine.c            | 10 ++--
 drivers/gpu/drm/xe/xe_hw_fence.c             |  2 +-
 drivers/gpu/drm/xe/xe_lrc.c                  |  8 +--
 drivers/gpu/drm/xe/xe_macros.h               |  9 +++-
 drivers/gpu/drm/xe/xe_migrate.c              | 34 ++++++------
 drivers/gpu/drm/xe/xe_pt.c                   | 22 ++++----
 drivers/gpu/drm/xe/xe_res_cursor.h           | 12 ++---
 drivers/gpu/drm/xe/xe_ring_ops.c             |  8 +--
 drivers/gpu/drm/xe/xe_sched_job.c            |  2 +-
 drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c       |  4 +-
 drivers/gpu/drm/xe/xe_uc_fw.c                | 16 +++---
 drivers/gpu/drm/xe/xe_uc_fw.h                |  2 +-
 drivers/gpu/drm/xe/xe_vm.c                   | 56 ++++++++++----------
 drivers/gpu/drm/xe/xe_wait_user_fence.c      |  2 +-
 drivers/gpu/drm/xe/xe_wopcm.c                | 18 +++----
 34 files changed, 228 insertions(+), 223 deletions(-)

-- 
2.34.1



More information about the Intel-xe mailing list