[Intel-xe] [PATCH V9 3/6] drm/xe: Add job timeout engine property to sysfs

[Matthew Brost]

On Thu, Jul 27, 2023 at 01:52:32PM +0530, Tejas Upadhyay wrote:
> The time after which a job is removed from the scheduler.
> Add sysfs entry to provide user defined job timeout to
> scheduler.
> 
> The job timeout can be adjusted per-engine class using,
> 
> /sys/class/drm/cardX/device/tileN/gtN/engines/ccs/job_timeout_ms
> 
> V7:
>   - Rebase to use s/xe_engine/xe_hw_engine/ - Matt
> V6:
>   - Remove timeout validation, not relevant - Niranjana
>   - Rebase to use common error path
> V5:
>   - Rebase to use engine class interface instead of hw engine
> V4:
>   - Rebase to per class engine props interface
> V3:
>   - Rebase
>   - Update commit message to reflect tile update
> V2:
>   - Use sysfs_create_files as part of this patch
> 
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>

Reviewed-by: Matthew Brost <matthew.brost at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c | 36 +++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c b/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c
> index 15c2b0b9f1fd..5e2dba0be8eb 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c
> +++ b/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c
> @@ -39,6 +39,34 @@ kobj_xe_hw_engine_class(struct kobject *parent, char *name)
>  	return keclass;
>  }
>  
> +static ssize_t job_timeout_store(struct kobject *kobj,
> +				 struct kobj_attribute *attr,
> +				 const char *buf, size_t count)
> +{
> +	struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
> +	u32 timeout;
> +	int err;
> +
> +	err = kstrtou32(buf, 0, &timeout);
> +	if (err)
> +		return err;
> +
> +	WRITE_ONCE(eclass->sched_props.job_timeout_ms, timeout);
> +
> +	return count;
> +}
> +
> +static ssize_t job_timeout_show(struct kobject *kobj,
> +				struct kobj_attribute *attr, char *buf)
> +{
> +	struct xe_hw_engine_class_intf *eclass = kobj_to_eclass(kobj);
> +
> +	return sprintf(buf, "%u\n", eclass->sched_props.job_timeout_ms);
> +}
> +
> +static struct kobj_attribute job_timeout_attr =
> +__ATTR(job_timeout_ms, 0644, job_timeout_show, job_timeout_store);
> +
>  static ssize_t job_timeout_default(struct kobject *kobj,
>  				   struct kobj_attribute *attr, char *buf)
>  {
> @@ -80,6 +108,11 @@ static const struct attribute *defaults[] = {
>  	NULL
>  };
>  
> +static const struct attribute *files[] = {
> +	&job_timeout_attr.attr,
> +	NULL
> +};
> +
>  static int xe_add_hw_engine_class_defaults(struct kobject *parent)
>  {
>  	struct kobject *kobj;
> @@ -182,6 +215,9 @@ int xe_hw_engine_class_sysfs_init(struct xe_gt *gt)
>  			goto err_object;
>  		}
>  
> +		err = sysfs_create_files(&keclass->base, files);
> +		if (err)
> +			goto err_object;
>  	}
>  
>  	return err;
> -- 
> 2.25.1
>