[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Introduce xe_ASSERT macros

Patchwork patchwork at emeril.freedesktop.org
Fri Jul 28 19:47:11 UTC 2023


== Series Details ==

Series: drm/xe: Introduce xe_ASSERT macros
URL   : https://patchwork.freedesktop.org/series/121549/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit b64fbee7ade07140df3f35ef6962cc07bd16b2e9
Author: Michal Wajdeczko <michal.wajdeczko at intel.com>
Date:   Fri Jul 28 21:25:18 2023 +0200

    drm/xe: Introduce xe_ASSERT macros
    
    As we are moving away from the controversial XE_BUG_ON macro,
    relying just on WARN_ON or drm_err does not cover the cases
    where we want to annotate functions with additional detailed
    debug checks to assert that all prerequisites are satisfied,
    without paying footprint or performance penalty on non-debug
    builds, where all misuses introduced during code integration
    were already fixed.
    
    Introduce family of xe_ASSERT macros that try to follow classic
    assert() utility and can be compiled out on non-debug builds.
    
    Macros are based on drm_WARN, but unlikely to origin, disallow
    use in expressions since we will compile that code out.
    
    As we are operating on the xe pointers, we can print additional
    information about the device, like tile or GT identifier, that
    is not available from generic WARN report:
    
    [ ] xe 0000:00:02.0: [drm] Assertion `false` failed!
        graphics: Xe_LP 12.0 media: Xe_M 12.0 GT0
    [ ] WARNING: CPU: 4 PID: 8442 at drivers/gpu/drm/xe/xe_device.c:280 xe_device_probe+0x2f5/0x4a0 [xe]
    [ ] RIP: 0010:xe_device_probe+0x2f5/0x4a0 [xe]
    
    Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Cc: Francois Dugast <francois.dugast at intel.com>
    Cc: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 353cf75540219b45ed346f2a3ba9418297278472 drm-intel
b64fbee7a drm/xe: Introduce xe_ASSERT macros
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:26: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#26: 
[ ] WARNING: CPU: 4 PID: 8442 at drivers/gpu/drm/xe/xe_device.c:280 xe_device_probe+0x2f5/0x4a0 [xe]

-:35: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

total: 0 errors, 2 warnings, 0 checks, 47 lines checked




More information about the Intel-xe mailing list