[Intel-xe] ✗ CI.checkpatch: warning for Rename engine to exec_queue

Patchwork patchwork at emeril.freedesktop.org
Mon Jul 31 16:12:47 UTC 2023


== Series Details ==

Series: Rename engine to exec_queue
URL   : https://patchwork.freedesktop.org/series/121627/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f8ca940e0d62b9cde562dee13eb95b1ca36586fc
Author: Francois Dugast <francois.dugast at intel.com>
Date:   Mon Jul 31 16:08:49 2023 +0000

    drm/xe: Rename engine to exec_queue
    
    Engine was inappropriately used to refer to execution queues and
    it also created some confusion with hardware engines. Where it applies
    the exec_queue variable name is changed to q and comments are also
    updated.
    
    Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/162
    Signed-off-by: Francois Dugast <francois.dugast at intel.com>
+ /mt/dim checkpatch d74e8f8407bc922b04ba50e8f4e888bedb31330a drm-intel
f8ca940e0 drm/xe: Rename engine to exec_queue
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:535: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#535: 
deleted file mode 100644

-:4129: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'q' may be better as '(q)' to avoid precedence issues
#4129: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:694:
+#define MAKE_SCHED_CONTEXT_ACTION(q, enable_disable)			\
 	u32 action[] = {						\
 		XE_GUC_ACTION_SCHED_CONTEXT_MODE_SET,			\
+		q->guc->id,						\
 		GUC_CONTEXT_##enable_disable,				\
 	}

-:7438: WARNING:LONG_LINE: line length of 134 exceeds 100 columns
#7438: FILE: include/uapi/drm/xe_drm.h:122:
+#define DRM_IOCTL_XE_EXEC_QUEUE_CREATE		DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_EXEC_QUEUE_CREATE, struct drm_xe_exec_queue_create)

-:7439: WARNING:LONG_LINE: line length of 146 exceeds 100 columns
#7439: FILE: include/uapi/drm/xe_drm.h:123:
+#define DRM_IOCTL_XE_EXEC_QUEUE_GET_PROPERTY	DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_EXEC_QUEUE_GET_PROPERTY, struct drm_xe_exec_queue_get_property)

-:7440: WARNING:LONG_LINE: line length of 136 exceeds 100 columns
#7440: FILE: include/uapi/drm/xe_drm.h:124:
+#define DRM_IOCTL_XE_EXEC_QUEUE_DESTROY		 DRM_IOW(DRM_COMMAND_BASE + DRM_XE_EXEC_QUEUE_DESTROY, struct drm_xe_exec_queue_destroy)

-:7444: WARNING:LONG_LINE: line length of 146 exceeds 100 columns
#7444: FILE: include/uapi/drm/xe_drm.h:127:
+#define DRM_IOCTL_XE_EXEC_QUEUE_SET_PROPERTY	 DRM_IOW(DRM_COMMAND_BASE + DRM_XE_EXEC_QUEUE_SET_PROPERTY, struct drm_xe_exec_queue_set_property)

total: 0 errors, 5 warnings, 1 checks, 6194 lines checked




More information about the Intel-xe mailing list