[Intel-xe] [PATCH] drm/xe: Add missing cursor offsets

[Lucas De Marchi]

On Wed, Mar 01, 2023 at 11:26:03AM +0100, Maarten Lankhorst wrote:
>Missed this when implementing display support. This allows the cursor
>to work properly on any pipe other than A.
>
>Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>---
> drivers/gpu/drm/xe/regs/xe_regs.h | 4 ++++
> drivers/gpu/drm/xe/xe_pci.c       | 6 ++++++
> 2 files changed, 10 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/regs/xe_regs.h b/drivers/gpu/drm/xe/regs/xe_regs.h
>index 2e7fbdedb5eb..c1c829c23df1 100644
>--- a/drivers/gpu/drm/xe/regs/xe_regs.h
>+++ b/drivers/gpu/drm/xe/regs/xe_regs.h
>@@ -69,6 +69,10 @@
> #define PIPE_D_OFFSET				0x73000
> #define PIPE_DSI0_OFFSET			0x7b000
> #define PIPE_DSI1_OFFSET			0x7b800
>+#define CURSOR_A_OFFSET				0x70080
>+#define CURSOR_B_OFFSET				0x71080
>+#define CURSOR_C_OFFSET				0x72080
>+#define CURSOR_D_OFFSET				0x73080
>
> #define SOFTWARE_FLAGS_SPR33			_MMIO(0x4f084)
>
>diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>index 11dc0de66101..a0802c288a94 100644
>--- a/drivers/gpu/drm/xe/xe_pci.c
>+++ b/drivers/gpu/drm/xe/xe_pci.c
>@@ -95,6 +95,12 @@ struct xe_device_desc {
> 			[TRANSCODER_DSI_0] = PIPE_DSI0_OFFSET, \
> 			[TRANSCODER_DSI_1] = PIPE_DSI1_OFFSET, \
> 		}, \
>+		.cursor_offsets = { \
>+			[PIPE_A] = CURSOR_A_OFFSET, \
>+			[PIPE_B] = CURSOR_B_OFFSET, \
>+			[PIPE_C] = CURSOR_C_OFFSET, \
>+			[PIPE_D] = CURSOR_D_OFFSET, \
>+		}, \


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

but I started moving all of the display's specific from this device desc
to another one in display/. Would that be ok?

Lucas De Marchi

> 		.trans_offsets = { \
> 			[TRANSCODER_A] = TRANSCODER_A_OFFSET, \
> 			[TRANSCODER_B] = TRANSCODER_B_OFFSET, \
>-- 
>2.34.1
>