[Intel-xe] [PATCH 2/2] drm/xe/tests: Grab a memory access reference around the migrate sanity test

Matthew Auld matthew.william.auld at gmail.com
Thu Mar 2 13:06:05 UTC 2023


On Thu, 2 Mar 2023 at 12:43, Thomas Hellström
<thomas.hellstrom at linux.intel.com> wrote:
>
> It appears we don't hold a memory access reference for the accesses in
> this test, which may results in printed warnings and possibly the GT
> not woken up for the memory accesses.
>
> Add a memory access reference around the test.
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>

Fixes those warnings for me,
Reviewed-by: Matthew Auld <matthew.auld at intel.com>


> ---
>  drivers/gpu/drm/xe/tests/xe_migrate.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/tests/xe_migrate.c b/drivers/gpu/drm/xe/tests/xe_migrate.c
> index 0de17e90aba9..b7e4a126e8b7 100644
> --- a/drivers/gpu/drm/xe/tests/xe_migrate.c
> +++ b/drivers/gpu/drm/xe/tests/xe_migrate.c
> @@ -366,7 +366,9 @@ static int migrate_test_run_device(struct xe_device *xe)
>
>                 kunit_info(test, "Testing gt id %d.\n", id);
>                 xe_vm_lock(m->eng->vm, &ww, 0, true);
> +               xe_device_mem_access_get(xe);
>                 xe_migrate_sanity_test(m, test);
> +               xe_device_mem_access_put(xe);
>                 xe_vm_unlock(m->eng->vm, &ww);
>         }
>
> --
> 2.39.2
>


More information about the Intel-xe mailing list