[Intel-xe] [PATCH 2/3] drm/xe: Constify xe_dss_mask_group_ffs()

Lucas De Marchi lucas.demarchi at intel.com
Mon Mar 6 18:17:11 UTC 2023


On Mon, Mar 06, 2023 at 08:08:09PM +0200, Jani Nikula wrote:
>On Mon, 06 Mar 2023, Lucas De Marchi <lucas.demarchi at intel.com> wrote:
>> Due to how xe_dss_mask_t is implemented, the type is a pointer.
>
>Per coding style, the fact that something is a pointer should not be
>hidden.

I don't like that typedef much neither, but currently there isn't much
option when using include/linux/bitmap.h. The alternative of not using a
typedef would mean the size of the array would need to be encoded
everywhere this is used.

Maybe this commit message needs to be reworded as the issue here is
that the array decays to a pointer when passed as argument to a function.
And the issue being handled would exist regardless of using or not a
typedef.

Lucas De Marchi


More information about the Intel-xe mailing list