[Intel-xe] [PATCH 2/6] drm/xe/mmio: s/lmem/vram/

Lucas De Marchi lucas.demarchi at intel.com
Tue Mar 7 16:26:06 UTC 2023


On Tue, Mar 07, 2023 at 11:27:07AM +0000, Matthew Auld wrote:
>On 07/03/2023 10:03, Gwan-gyeong Mun wrote:
>>Looks good to me.
>>Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun at intel.com>
>
>Thanks.
>
>>
>>In addition, in the code of the function below, a variable or string 
>>named lmem is used. Is the code intentionally not modified?
>>
>>drivers/gpu/drm/xe/xe_bo.c
>>     xe_bo_pin()
>>
>>drivers/gpu/drm/xe/tests/xe_migrate.c
>>     test_copy()
>
>Yeah, it seems there are a bunch more places. But here since I was 
>only really touching xe_mmio.c, adding the plumbing for io_size, I 
>figured to limit to here for now. Also there were some existing user 
>level prints and modparams directly related to this series (like 
>lmem_bar_size), so seemed worth fixing those in particular.
>
>I suppose I can re-resend with s/lmem/vram/ for the whole driver.

yeah... I think it would be good.


Acked-by: Lucas De Marchi <lucas.demarchi at intel.com>

for that approach

thanks,
Lucas De Marchi


More information about the Intel-xe mailing list