[Intel-xe] [PATCH 09/19] drm/xe: Name LRC wa after the engine it belongs

[Lucas De Marchi]

On Wed, Mar 08, 2023 at 02:16:22PM -0800, Matt Roper wrote:
>On Tue, Mar 07, 2023 at 01:24:36AM -0800, Lucas De Marchi wrote:
>> This makes it easier when printing the register-save-restore values
>> to know what is the engine.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_gt.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
>> index 343370b44506..daa433d0f2f5 100644
>> --- a/drivers/gpu/drm/xe/xe_gt.c
>> +++ b/drivers/gpu/drm/xe/xe_gt.c
>> @@ -318,7 +318,7 @@ int xe_gt_record_default_lrcs(struct xe_gt *gt)
>>  		if (gt->default_lrc[hwe->class])
>>  			continue;
>>
>> -		xe_reg_sr_init(&hwe->reg_lrc, "LRC", xe);
>> +		xe_reg_sr_init(&hwe->reg_lrc, hwe->name, xe);
>
>Does the LRC sr's name actually get printed anywhere today?  I'm not
>seeing it from a quick skim.

in this series: drm/xe/debugfs: Dump register save-restore tables

Intention is to have a register-save-restore in debugfs to go through
each of the sr's, dumping them. The name itself is printed by
xe_reg_sr.c, while the type is printed by debugfs. I skipped the
whitelist in that patch, but I can add it there. It will match fine
where I print this info.

>
>Assuming we do start printing the name at some point, we'll just need to
>make sure the message is different enough from the ones printed for the
>engine and whitelist sr's since they also use the same engine name.
>
>Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

thanks
Lucas De Marchi

>
>>  		xe_wa_process_lrc(hwe);
>>  		xe_tuning_process_lrc(hwe);
>>
>> --
>> 2.39.0
>>
>
>-- 
>Matt Roper
>Graphics Software Engineer
>Linux GPU Platform Enablement
>Intel Corporation