[Intel-xe] [PATCH v2 05/12] drm/xe: Remove policy on preemption from WAs

Lucas De Marchi lucas.demarchi at intel.com
Fri Mar 10 22:15:42 UTC 2023


The fake WA FtrPerCtxtPreemptionGranularityControl is documented in i915
and is not a true WA, it's a policy chosen to allow preemption settings
to be controlled on a per-context basis by userspace.  The policy for
the xe driver is to be decided, and if the same is chosen, it should be
set in another place, like xe_tuning.c. Certainly not the place it
currently is.

Suggested-by: Matt Roper <matthew.d.roper at intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
---
 drivers/gpu/drm/xe/xe_wa.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
index 67539f9d70b4..76c603dfc030 100644
--- a/drivers/gpu/drm/xe/xe_wa.c
+++ b/drivers/gpu/drm/xe/xe_wa.c
@@ -236,12 +236,6 @@ static const struct xe_rtp_entry engine_was[] = {
 	  XE_RTP_ACTIONS(SET(GEN10_SAMPLER_MODE, ENABLE_SMALLPL,
 			     XE_RTP_ACTION_FLAG(MASKED_REG)))
 	},
-	{ XE_RTP_NAME("FtrPerCtxtPreemptionGranularityControl"),
-	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, 1250), ENGINE_CLASS(RENDER)),
-	  XE_RTP_ACTIONS(SET(GEN7_FF_SLICE_CS_CHICKEN1,
-			     GEN9_FFSC_PERCTX_PREEMPT_CTRL,
-			     XE_RTP_ACTION_FLAG(MASKED_REG)))
-	},
 	{}
 };
 
-- 
2.39.0



More information about the Intel-xe mailing list