[Intel-xe] [PATCH] drm/xe: Fix module load without display IP

[Lucas De Marchi]

On Fri, Mar 17, 2023 at 04:46:58PM +0100, Mauro Carvalho Chehab wrote:
>
>On 3/10/23 20:14, Lucas De Marchi wrote:
>>When the device info initialization moved to the display part, one use
>>case was left behind: platforms without display IP. In order to keep the
>>knowledge about the display in xe_display.c, xe_display_info_init()
>>should be the place where this is set.
>>
>>Remove the warning and set the info accordingly. This moves a later
>>check from  intel_device_info_runtime_init() into a very earlier one,
>>when no HW access is being done yet.
>>
>>Fixes: 01a4268df2dd ("drm/xe/display: Move device info initialization to display")
>>Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>Reviewed-by: Mauro Carvalho Chehab <mchehab at kernel.org>

missed the xe mailing list, adding it back.

>>---
>>
>>This fixes the module loading for me in PVC as long as I also remove
>>the ast module, due to another unrelated issue.
>>
>>I do wonder though about the need for the drm.driver_features dance. We
>>set it very early on probe to call aperture_remove_conflicting_pci_framebuffers(),
>>which may be needed if the device supports display, but should not be
>>driven by xe.  For now fixing just the most immediate issue that should
>>bring us back to the behavior we had before the commit being fixed.


I'll push this to fixup PVC and think about this later.

thanks
Lucas De Marchi