[Intel-xe] [PATCH] drm/xe: Decrement fault mode counts in xe_vm_close_and_put

Lucas De Marchi lucas.demarchi at intel.com
Sat Mar 18 04:35:36 UTC 2023


On Fri, Mar 17, 2023 at 09:35:24PM +0000, Matthew Brost wrote:
>On Fri, Mar 17, 2023 at 08:45:03AM -0700, Lucas De Marchi wrote:
>> On Thu, Mar 16, 2023 at 11:22:13PM -0700, Matthew Brost wrote:
>> > Rather waiting for the VM to be destroyed (all refs to VM go to zero),
>> > drop the fault mode counts when the VM is closed in xe_vm_close_and_put.
>> > This avoids a window where user space can create a faulting VM, close
>> > it, and a subsequent creation of a non-faulting VM fails.
>> >
>> > VLK-45296
>>
>> you have garbage leftover here. Please open an issue in gitlab to be
>> able to reference it.
>>
>
>So no referencing internal Jiras? I thought iy fine to do so.

no, it's not. It means nothing externally. The only acceptable number is
a bspec reference, probably for historic reasons.

in upstream we should be using

"References: <issue in a public location that has more details/discussion around what's being fixed>"

Lucas De Marchi

>
>Matt
>
>> Lucas De Marchi


More information about the Intel-xe mailing list