[Intel-xe] [PATCH] drm/xe/pat: Define PAT tables as static

Das, Nirmoy nirmoy.das at linux.intel.com
Mon Mar 27 18:45:35 UTC 2023


On 3/27/2023 7:58 PM, Matt Roper wrote:
> The tables are only used within this file; there's no reason for them
> not to be static.
>
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>


Reviewed-by: Nirmoy Das <nirmoy.das at intel.com>

> ---
>   drivers/gpu/drm/xe/xe_pat.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pat.c b/drivers/gpu/drm/xe/xe_pat.c
> index c860b2122301..be1bea58378a 100644
> --- a/drivers/gpu/drm/xe/xe_pat.c
> +++ b/drivers/gpu/drm/xe/xe_pat.c
> @@ -30,7 +30,7 @@
>   #define TGL_PAT_WC				REG_FIELD_PREP(TGL_MEM_TYPE_MASK, 1)
>   #define TGL_PAT_UC				REG_FIELD_PREP(TGL_MEM_TYPE_MASK, 0)
>   
> -const u32 tgl_pat_table[] = {
> +static const u32 tgl_pat_table[] = {
>   	[0] = TGL_PAT_WB,
>   	[1] = TGL_PAT_WC,
>   	[2] = TGL_PAT_WT,
> @@ -41,7 +41,7 @@ const u32 tgl_pat_table[] = {
>   	[7] = TGL_PAT_WB,
>   };
>   
> -const u32 pvc_pat_table[] = {
> +static const u32 pvc_pat_table[] = {
>   	[0] = TGL_PAT_UC,
>   	[1] = TGL_PAT_WC,
>   	[2] = TGL_PAT_WT,
> @@ -52,7 +52,7 @@ const u32 pvc_pat_table[] = {
>   	[7] = PVC_PAT_CLOS(2) | TGL_PAT_WB,
>   };
>   
> -const u32 mtl_pat_table[] = {
> +static const u32 mtl_pat_table[] = {
>   	[0] = MTL_PAT_0_WB,
>   	[1] = MTL_PAT_1_WT,
>   	[2] = MTL_PAT_3_UC,


More information about the Intel-xe mailing list