[Intel-xe] [PATCH] fixup! drm/xe/pat: Handle unicast vs MCR PAT registers

[Matt Roper]

On Mon, Mar 27, 2023 at 11:50:33PM +0200, Andi Shyti wrote:
> Hi Matt,
> 
> On Mon, Mar 27, 2023 at 10:34:33AM -0700, Matt Roper wrote:
> > Somehow I dropped the error message when sending this; add it back.
> > 
> > To be squashed next time the Xe driver is rebased.
> > 
> > Fixes: 11946af00717 ("drm/xe/pat: Handle unicast vs MCR PAT registers")
> 
> I don't think you need the Fixes tag here as this is not a fix.

True.  But this whole patch will disappear the next time we rebase the
Xe tree so the 'Fixes:' won't propagate anywhere.  Maybe Fixes: wasn't
the best term to use here, but I wanted to give a quick reference to
exactly which patch this is expected to get squashed into that would be
easier than searching for the title.


Matt

> 
> Andi
> 
> > Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_pat.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_pat.c b/drivers/gpu/drm/xe/xe_pat.c
> > index a713afdd0510..c860b2122301 100644
> > --- a/drivers/gpu/drm/xe/xe_pat.c
> > +++ b/drivers/gpu/drm/xe/xe_pat.c
> > @@ -94,5 +94,7 @@ void xe_pat_init(struct xe_gt *gt)
> >  		 * raise an error rather than trying to silently inherit the
> >  		 * most recent platform's behavior.
> >  		 */
> > +		drm_err(&xe->drm, "Missing PAT table for platform with graphics version %d.%2d!\n",
> > +			GRAPHICS_VER(xe), GRAPHICS_VERx100(xe) % 100);
> >  	}
> >  }
> > -- 
> > 2.39.2
> > 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation