[Intel-xe] [PATCH 1/2] drm/xe: Better error messages for xe_gt_record_default_lrcs

[Michal Wajdeczko]

On 28.03.2023 21:58, Matthew Brost wrote:
> Add some error messages describing the problem when
> xe_gt_record_default_lrcs fails.
> 
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt.c | 23 ++++++++++++++++++++---
>  1 file changed, 20 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 6322e0689a9e..724ba2be5d3d 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -23,6 +23,7 @@
>  #include "xe_gt_sysfs.h"
>  #include "xe_gt_tlb_invalidation.h"
>  #include "xe_gt_topology.h"
> +#include "xe_guc_engine_types.h"
>  #include "xe_hw_fence.h"
>  #include "xe_irq.h"
>  #include "xe_lrc.h"
> @@ -257,30 +258,46 @@ int xe_gt_record_default_lrcs(struct xe_gt *gt)
>  				     hwe, ENGINE_FLAG_WA);
>  		if (IS_ERR(e)) {
>  			err = PTR_ERR(e);
> +			drm_err(&xe->drm, "gt%d, hwe %d:%d, xe_engine_create,e failed=%d",
> +				gt->info.id, hwe->class, hwe->instance, err);

btw, there is pending series that would print GT%u for you

	#include "xe_gt_printk.h"

	xe_gt_err(gt, "hwe %d:%d, ...

[1] https://patchwork.freedesktop.org/series/115083/