[Intel-xe] [PATCH 11/18] fixup! drm/xe: Introduce a new DRM driver for Intel GPUs

[Oded Gabbay]

On Wed, May 3, 2023 at 4:59 PM Rodrigo Vivi <rodrigo.vivi at kernel.org> wrote:
>
> On Wed, May 03, 2023 at 04:09:58PM +0300, Jani Nikula wrote:
> > Add the read8 accessor to support intel_de_read8.
> >
> > Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>
> I wonder if we should have this as a new separated patch instead of a fixup?
> Then when rebasing with autosquash we make sure to put this before the
> xe/display patches...
>
> Oded has already started to review the xe-rev1 branch and I'd like
> to avoid changes to the patches that are in that branch already.
>
> But this is really small, probably with his ack we can keep as this fixup!
I haven't managed to do a lot yet, so keeping this patch as fixup is fine.
Oded
>
> > ---
> >  drivers/gpu/drm/xe/xe_mmio.h | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_mmio.h b/drivers/gpu/drm/xe/xe_mmio.h
> > index 1a32e0f52261..b72a0a75259f 100644
> > --- a/drivers/gpu/drm/xe/xe_mmio.h
> > +++ b/drivers/gpu/drm/xe/xe_mmio.h
> > @@ -17,6 +17,14 @@ struct xe_device;
> >
> >  int xe_mmio_init(struct xe_device *xe);
> >
> > +static inline u8 xe_mmio_read8(struct xe_gt *gt, u32 reg)
> > +{
> > +     if (reg < gt->mmio.adj_limit)
> > +             reg += gt->mmio.adj_offset;
> > +
> > +     return readb(gt->mmio.regs + reg);
> > +}
> > +
> >  static inline void xe_mmio_write32(struct xe_gt *gt,
> >                                  u32 reg, u32 val)
> >  {
> > --
> > 2.39.2
> >