[Intel-xe] [PATCH 1/7] drm/xe: Do not mark 1809175790 as a WA

Rodrigo Vivi rodrigo.vivi at kernel.org
Thu May 4 16:10:21 UTC 2023


On Thu, May 04, 2023 at 12:32:44AM -0700, Lucas De Marchi wrote:
> Additional programming annotated with Wa_<number> should be reserved to
> those that have a official workaround. Just pointing to a bug or
> additional reference can be done with something else. Copy what i915
> does and refer to it as "hsdes: ....".
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_ring_ops.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_ring_ops.c b/drivers/gpu/drm/xe/xe_ring_ops.c
> index 5e61b6e61f3a..75838b8bb9a8 100644
> --- a/drivers/gpu/drm/xe/xe_ring_ops.c
> +++ b/drivers/gpu/drm/xe/xe_ring_ops.c
> @@ -199,7 +199,8 @@ static void __emit_job_gen12_video(struct xe_sched_job *job, struct xe_lrc *lrc,
>  	bool decode = job->engine->class == XE_ENGINE_CLASS_VIDEO_DECODE;
>  
>  	dw[i++] = preparser_disable(true);
> -	/* Wa_1809175790 */
> +
> +	/* hsdes: 1809175790 */
>  	if (!xe->info.has_flat_ccs) {
>  		if (decode)
>  			i = emit_aux_table_inv(gt, VD0_AUX_NV.reg, dw, i);
> @@ -244,9 +245,11 @@ static void __emit_job_gen12_render_compute(struct xe_sched_job *job,
>  	else if (job->engine->class == XE_ENGINE_CLASS_COMPUTE)
>  		mask_flags = PIPE_CONTROL_3D_ENGINE_FLAGS;
>  	i = emit_pipe_invalidate(mask_flags, dw, i);
> -	/* Wa_1809175790 */
> +
> +	/* hsdes: 1809175790 */
>  	if (!xe->info.has_flat_ccs)
>  		i = emit_aux_table_inv(gt, GFX_CCS_AUX_NV.reg, dw, i);
> +
>  	dw[i++] = preparser_disable(false);
>  
>  	i = emit_store_imm_ggtt(xe_lrc_start_seqno_ggtt_addr(lrc),
> -- 
> 2.40.1
> 


More information about the Intel-xe mailing list