[Intel-xe] [PATCH v2 16/31] drm/xe: Port Xe to GPUVA

[Thomas Hellström]

Hi, Matthew,

On 5/2/23 02:17, Matthew Brost wrote:
> Rather than open coding VM binds and VMA tracking, use the GPUVA
> library. GPUVA provides a common infrastructure for VM binds to use mmap
> / munmap semantics and support for VK sparse bindings.
>
> The concepts are:
>
> 1) xe_vm inherits from drm_gpuva_manager
> 2) xe_vma inherits from drm_gpuva
> 3) xe_vma_op inherits from drm_gpuva_op
> 4) VM bind operations (MAP, UNMAP, PREFETCH, UNMAP_ALL) call into the
> GPUVA code to generate an VMA operations list which is parsed, commited,
> and executed.
>
> v2 (CI): Add break after default in case statement.
> v3: Rebase
> v4: Fix some error handling
>
> Signed-off-by: Matthew Brost <matthew.brost at intel.com>

Before embarking on a second review of this code it would really be 
beneficial if you could address some comments from the first review. In 
particular splitting this huge patch up if possible (and I also think 
that removing the async worker *before* this patch if at all possible 
would really ease the review both for me and potential upcoming reviewers).

Thanks,

Thomas