[Intel-xe] [PATCH] drm/xe: Make xe build dependent on STAGING.

[Greg Kroah-Hartman]

On Tue, May 09, 2023 at 09:56:33AM -0700, Lucas De Marchi wrote:
> On Tue, May 09, 2023 at 11:10:08AM -0400, Rodrigo Vivi wrote:
> > As documented in drivers/staging/Kconfig:
> > 
> > STAGING means "that these drivers are under heavy development" and
> > "may contain userspace interfaces that most likely will be changed
> > in the near future."
> > 
> > As explained in Documentation/gpu/rfc/xe.rst:
> > 
> > "
> > Xe driver will be protected with both STAGING Kconfig and force_probe.
> > Changes in the uAPI are expected while the driver is behind these
> > protections. STAGING will be removed when the driver uAPI gets to a
> > mature state where we can guarantee the ‘no regression’ rule.
> > Then force_probe will be lifted only for future platforms that will be
> > productized with Xe driver, but not with i915.
> > "
> > 
> > Cc: Mauro Carvalho Chehab <mchehab at kernel.org>
> > Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> > Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenberg at intel.com>
> > Cc: Maciej Ramotowski <maciej.ramotowski at intel.com>
> > Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> 
> I agree with the idea, but I was expecting a few more hits:
> 
> 	$ git grep "\bSTAGING\b" -- '*Kconfig'
> 	drivers/gpu/drm/nouveau/Kconfig:        depends on STAGING
> 	drivers/gpu/drm/tegra/Kconfig:  depends on STAGING
> 	drivers/staging/Kconfig:menuconfig STAGING
> 	drivers/staging/Kconfig:if STAGING
> 	drivers/staging/Kconfig:endif # STAGING
> 	drivers/staging/vme_user/Kconfig:       depends on STAGING && PCI
> 	drivers/staging/vme_user/Kconfig:       depends on STAGING && VME_BUS
> 
> Are we doing something wrong here? Documentation/process/2.Process.rst
> talks about drivers under staging/ directory rather than drivers
> depending on CONFIG_STAGING.

Yes, you are doing something wrong here :)

CONFIG_STAGING is only to be used for drivers/staging/.  But I will not
take drm drivers into that directory as the DRM developers don't want me
to (and that's wonderful, no objection from me).

If you just use the CONFIG dependancy here you will not get the taint
flag set properly if they are out of that directory (and you want that
taint flag, TAINT_CRAP is there for that reason.)

But hey, it's your subsystem, if you want to depend on this random
config variable, wonderful!  But realize that it means nothing, and has
nothing to do with user/kernel api stability issues at all.

thanks,

greg k-h