[Intel-xe] [PATCH] drm/xe: Unlink display before turning off irq

Das, Nirmoy nirmoy.das at intel.com
Wed May 10 13:18:21 UTC 2023


On 5/10/2023 3:09 PM, Jani Nikula wrote:
> On Wed, 10 May 2023, Nirmoy Das <nirmoy.das at intel.com> wrote:
>> Unlinking display will lead to guc tlb inval timeout for
>> the fbdev vma as irqs are disabled.
> fixup to display enabling?


Works for me. Do you want me to resend this with fixup! tag ? I am fine 
if you do that while merging it.


Regards,

Nirmoy

>
> BR,
> Jani.
>
>> Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_device.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
>> index 32cc83c43b2a..430bd6eb4053 100644
>> --- a/drivers/gpu/drm/xe/xe_device.c
>> +++ b/drivers/gpu/drm/xe/xe_device.c
>> @@ -349,9 +349,9 @@ void xe_device_remove(struct xe_device *xe)
>>   {
>>   	xe_device_remove_display(xe);
>>   
>> -	xe_irq_shutdown(xe);
>> -
>>   	xe_display_unlink(xe);
>> +
>> +	xe_irq_shutdown(xe);
>>   }
>>   
>>   void xe_device_shutdown(struct xe_device *xe)


More information about the Intel-xe mailing list