[Intel-xe] [PATCH 3/4] drm/xe/display: Consider has_display to enable it

Lucas De Marchi lucas.demarchi at intel.com
Thu May 11 17:12:38 UTC 2023


On Thu, May 11, 2023 at 06:34:46PM +0300, Jani Nikula wrote:
>On Thu, 11 May 2023, "Souza, Jose" <jose.souza at intel.com> wrote:
>> On Wed, 2023-05-10 at 12:54 -0700, Lucas De Marchi wrote:
>>> Stop the dance of enabling the display-related driver_features to later
>>> disable them on display info init if the platform doesn't have display
>>> IP. Besides being needless work, it wasn't covering the ATS-M case that
>>> is the same platform as DG2, but without display.
>>
>> Xe should set pipe_mask = 0 and call i915 functions that will handle no display cases.
>> Also intel_device_info_runtime_init() needs to be called earlier, as pipes could be fused off and there is a case for discrete platforms with display
>>>= 14 that can have display fused off too.
>
>Agreed, seems like this duplicates HAS_DISPLAY() which operates on
>pipe_mask, and takes fusing into account.

see reply to Jose. They are different things.

Lucas De Marchi


More information about the Intel-xe mailing list