[Intel-xe] [PATCH v3 1/2] drm/xe: Introduce GT oriented log messages

[Matt Roper]

On Thu, May 11, 2023 at 06:56:35PM +0200, Michal Wajdeczko wrote:
> While debugging GT related problems, it's good to know which GT was
> reporting problems. Introduce helper macros to allow prefix GT logs
> with GT idetifier. We will use them in upcoming patches.

Minor typo in "identifier."  Otherwise,

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

This will be a _huge_ help when reading the logs and debugging issues on
PVC, MTL, and all future platforms.


Matt

> 
> v2: use xe_ prefix (Lucas)
> v3: use correct include
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_printk.h | 46 +++++++++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 drivers/gpu/drm/xe/xe_gt_printk.h
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_printk.h b/drivers/gpu/drm/xe/xe_gt_printk.h
> new file mode 100644
> index 000000000000..0b801429cf1a
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/xe_gt_printk.h
> @@ -0,0 +1,46 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2023 Intel Corporation
> + */
> +
> +#ifndef _XE_GT_PRINTK_H_
> +#define _XE_GT_PRINTK_H_
> +
> +#include <drm/drm_print.h>
> +
> +#include "xe_device_types.h"
> +
> +#define xe_gt_printk(_gt, _level, _fmt, ...) \
> +	drm_##_level(&(_gt)->xe->drm, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
> +
> +#define xe_gt_err(_gt, _fmt, ...) \
> +	xe_gt_printk((_gt), err, _fmt, ##__VA_ARGS__)
> +
> +#define xe_gt_warn(_gt, _fmt, ...) \
> +	xe_gt_printk((_gt), warn, _fmt, ##__VA_ARGS__)
> +
> +#define xe_gt_notice(_gt, _fmt, ...) \
> +	xe_gt_printk((_gt), notice, _fmt, ##__VA_ARGS__)
> +
> +#define xe_gt_info(_gt, _fmt, ...) \
> +	xe_gt_printk((_gt), info, _fmt, ##__VA_ARGS__)
> +
> +#define xe_gt_dbg(_gt, _fmt, ...) \
> +	xe_gt_printk((_gt), dbg, _fmt, ##__VA_ARGS__)
> +
> +#define xe_gt_err_ratelimited(_gt, _fmt, ...) \
> +	xe_gt_printk((_gt), err_ratelimited, _fmt, ##__VA_ARGS__)
> +
> +#define xe_gt_WARN(_gt, _condition, _fmt, ...) \
> +	drm_WARN(&(_gt)->xe->drm, _condition, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
> +
> +#define xe_gt_WARN_ONCE(_gt, _condition, _fmt, ...) \
> +	drm_WARN_ONCE(&(_gt)->xe->drm, _condition, "GT%u: " _fmt, (_gt)->info.id, ##__VA_ARGS__)
> +
> +#define xe_gt_WARN_ON(_gt, _condition) \
> +	xe_gt_WARN((_gt), _condition, "%s(%s)", "gt_WARN_ON", __stringify(_condition))
> +
> +#define xe_gt_WARN_ON_ONCE(_gt, _condition) \
> +	xe_gt_WARN_ONCE((_gt), _condition, "%s(%s)", "gt_WARN_ON_ONCE", __stringify(_condition))
> +
> +#endif
> -- 
> 2.25.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation