[Intel-xe] [PATCH 14/26] drm/xe: Move display IRQ postinstall out of GT function

Rodrigo Vivi rodrigo.vivi at kernel.org
Thu May 18 17:51:31 UTC 2023


On Wed, May 10, 2023 at 08:47:10PM -0700, Matt Roper wrote:
> Display interrupts are unrelated to the GT (and are also only relevant
> to the root tile).  Move the postinstall call up a level in the
> callstack.

good catch!

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>


> 
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index 806121009102..494ec5567e50 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -490,8 +490,6 @@ void xe_gt_irq_postinstall(struct xe_gt *gt)
>  		dg1_irq_postinstall(xe, gt);
>  	else
>  		xelp_irq_postinstall(xe, gt);
> -
> -	xe_display_irq_postinstall(xe, gt);
>  }
>  
>  static void xe_irq_postinstall(struct xe_device *xe)
> @@ -501,6 +499,8 @@ static void xe_irq_postinstall(struct xe_device *xe)
>  
>  	for_each_gt(gt, xe, id)
>  		xe_gt_irq_postinstall(gt);
> +
> +	xe_display_irq_postinstall(xe, xe_primary_mmio_gt(xe));
>  }
>  
>  static irq_handler_t xe_irq_handler(struct xe_device *xe)
> -- 
> 2.40.0
> 


More information about the Intel-xe mailing list