[Intel-xe] [PATCH 17/26] drm/xe/irq: Actually call xe_irq_postinstall()

Lucas De Marchi lucas.demarchi at intel.com
Thu May 18 18:40:01 UTC 2023


On Wed, May 10, 2023 at 08:47:13PM -0700, Matt Roper wrote:
>The xe_irq_postinstall() never actually gets called after installing the
>interrupt handler.  This oversight seems to get papered over due to the
>fact that the (misnamed) xe_gt_irq_postinstall does more than it really
>should and gets called in the middle of the GT initialization.

shouldn't we then fix that in the same patch too, moving the call to be
inside xe_irq?

Lucas De Marchi

>
>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
>---
> drivers/gpu/drm/xe/xe_irq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
>index 02f44b58ce3e..2549fd9fb5cd 100644
>--- a/drivers/gpu/drm/xe/xe_irq.c
>+++ b/drivers/gpu/drm/xe/xe_irq.c
>@@ -588,6 +588,8 @@ int xe_irq_install(struct xe_device *xe)
> 		return err;
> 	}
>
>+	xe_irq_postinstall(xe);
>+
> 	err = drmm_add_action_or_reset(&xe->drm, irq_uninstall, xe);
> 	if (err)
> 		return err;
>-- 
>2.40.0
>


More information about the Intel-xe mailing list