[Intel-xe] [PATCH v2] fixup! drm/xe/rtp: Improve magic macros for RTP tables

[Matt Roper]

On Thu, May 18, 2023 at 04:02:22PM -0700, Lucas De Marchi wrote:
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_rtp.h | 17 +++++++----------
>  1 file changed, 7 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_rtp.h b/drivers/gpu/drm/xe/xe_rtp.h
> index 8bc946694bfc..8a89ad45589a 100644
> --- a/drivers/gpu/drm/xe/xe_rtp.h
> +++ b/drivers/gpu/drm/xe/xe_rtp.h
> @@ -262,11 +262,10 @@ struct xe_reg_sr;
>  
>  /**
>   * XE_RTP_ENTRY_FLAG - Helper to add multiple flags to a struct xe_rtp_entry
> - * @f1_: Last part of a ``XE_RTP_ENTRY_FLAG_*``
> - * @...: Additional flags, defined like @f1_
> + * @...: Entry flags, without the ``XE_RTP_ENTRY_FLAG_`` prefix
>   *
> - * Helper to automatically add a ``XE_RTP_ENTRY_FLAG_`` prefix to @f1_ so it can
> - * be easily used to define struct xe_rtp_action entries. Example:
> + * Helper to automatically add a ``XE_RTP_ENTRY_FLAG_`` prefix to the flags
> + * when defining struct xe_rtp_entry entries. Example:
>   *
>   * .. code-block:: c
>   *
> @@ -285,11 +284,10 @@ struct xe_reg_sr;
>  
>  /**
>   * XE_RTP_ACTION_FLAG - Helper to add multiple flags to a struct xe_rtp_action
> - * @f1_: Last part of a ``XE_RTP_ENTRY_*``
> - * @...: Additional flags, defined like @f1_
> + * @...: Action flags, without the ``XE_RTP_ACTION_FLAG_`` prefix
>   *
> - * Helper to automatically add a ``XE_RTP_ACTION_FLAG_`` prefix to @f1_ so it
> - * can be easily used to define struct xe_rtp_action entries. Example:
> + * Helper to automatically add a ``XE_RTP_ACTION_FLAG_`` prefix to the flags
> + * when defining struct xe_rtp_action entries. Example:
>   *
>   * .. code-block:: c
>   *
> @@ -308,8 +306,7 @@ struct xe_reg_sr;
>  
>  /**
>   * XE_RTP_RULES - Helper to set multiple rules to a struct xe_rtp_entry entry
> - * @r1: Last part of XE_RTP_MATCH_*
> - * @...: Additional rules, defined like @r1
> + * @...: Rules
>   *
>   * At least one rule is needed and up to 4 are supported. Multiple rules are
>   * AND'ed together, i.e. all the rules must evaluate to true for the entry to
> -- 
> 2.40.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation