[Intel-xe] [PATCH] drm/xe: Change GuC interrupt data

Lucas De Marchi lucas.demarchi at intel.com
Sat May 20 05:00:46 UTC 2023


On Fri, May 19, 2023 at 06:49:53PM +0200, Michal Wajdeczko wrote:
>
>
>On 19.05.2023 18:39, Matt Roper wrote:
>> On Fri, May 19, 2023 at 11:56:18AM +0200, Michal Wajdeczko wrote:
>>> Both GUC_HOST_INTERRUPT and MED_GUC_HOST_INTERRUPT can pass
>>> additional payload data to the GuC but this capability is not
>>> used by the firmware yet.
>>>
>>> Stop using value mandated by legacy GuC interrupt register and
>>> use default notify value (zero) instead.
>>>
>>> Bspec: 49813, 63363
>>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>>
>> Looks like GUC_SEND_TRIGGER was only relevant to the old
>> HOST2GUC_INT_REG register (0xc4c8) that was used through gen9.  Should
>> we remove the #define for that bit from the header as well?
>
>I've already prepared follow up patches to fix that, will post now:
>
>drm/xe: Reorder GuC interrupt register definition

that would be better a commit reordering the header, possibly in an
automated/mechanical way.

>drm/xe: Drop legacy GuC interrupt register definition

better not leave the unused define so this removal should be done
together with the last user of it.

Lucas De Marchi


More information about the Intel-xe mailing list