[Intel-xe] [PATCH] drm/xe: fix kernel-doc issues

Matthew Auld matthew.auld at intel.com
Mon May 22 11:39:31 UTC 2023


On 22/05/2023 12:07, Das, Nirmoy wrote:
> 
> On 5/22/2023 1:01 PM, Matthew Auld wrote:
>> drivers/gpu/drm/xe/xe_guc_submit_types.h:47: warning: cannot understand
>> function prototype: 'struct guc_submit_parallel_scratch '
>>
>> drivers/gpu/drm/xe/xe_devcoredump_types.h:38: warning: Function
>> parameter or member 'ct' not described in 'xe_devcoredump_snapshot'
>>
>> CI doesn't appear to be running BAT anymore, assuming this is caused by
>> the CI.Hooks now failing due to above warnings.
>>
>> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Reviewed-by: Nirmoy Das <nirmoy.das at intel.com>

Thanks. Looks like CI is now reporting BAT results again with this.

>> ---
>>   drivers/gpu/drm/xe/xe_devcoredump_types.h | 2 +-
>>   drivers/gpu/drm/xe/xe_guc_submit_types.h  | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_devcoredump_types.h 
>> b/drivers/gpu/drm/xe/xe_devcoredump_types.h
>> index 350b905d1797..c0d711eb6ab3 100644
>> --- a/drivers/gpu/drm/xe/xe_devcoredump_types.h
>> +++ b/drivers/gpu/drm/xe/xe_devcoredump_types.h
>> @@ -27,7 +27,7 @@ struct xe_devcoredump_snapshot {
>>       ktime_t boot_time;
>>       /* GuC snapshots */
>> -    /** @ct_snapshot: GuC CT snapshot */
>> +    /** @ct: GuC CT snapshot */
>>       struct xe_guc_ct_snapshot *ct;
>>       /** @ge: Guc Engine snapshot */
>>       struct xe_guc_submit_engine_snapshot *ge;
>> diff --git a/drivers/gpu/drm/xe/xe_guc_submit_types.h 
>> b/drivers/gpu/drm/xe/xe_guc_submit_types.h
>> index 88e855dae056..6765b2c6eab1 100644
>> --- a/drivers/gpu/drm/xe/xe_guc_submit_types.h
>> +++ b/drivers/gpu/drm/xe/xe_guc_submit_types.h
>> @@ -41,7 +41,7 @@ struct sync_semaphore {
>>   };
>>   /**
>> - * Struct guc_submit_parallel_scratch - A scratch shared mapped buffer.
>> + * struct guc_submit_parallel_scratch - A scratch shared mapped buffer.
>>    */
>>   struct guc_submit_parallel_scratch {
>>       /** @wq_desc: Guc scheduler workqueue descriptor */


More information about the Intel-xe mailing list