[Intel-xe] [PATCH 2/2] xe/rpls: Add Stepping info for RPLS

Matt Roper matthew.d.roper at intel.com
Tue May 23 23:53:24 UTC 2023


On Mon, May 22, 2023 at 12:35:41PM -0700, Anusha Srivatsa wrote:
> Add stepping-substepping info.
> Though it looks weird, the revision ID
> for the newer stepping is indeed backwards
> and is in accordance to the spec.

You may want to re-wrap this commit message; it's super narrow.  Also,
the same issue as patch #1 with the subject prefix.  Aside from those
minor issues,

        Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

> 
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_step.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_step.c b/drivers/gpu/drm/xe/xe_step.c
> index a443d9bd7bbb..08c3ccb7d537 100644
> --- a/drivers/gpu/drm/xe/xe_step.c
> +++ b/drivers/gpu/drm/xe/xe_step.c
> @@ -60,6 +60,11 @@ static const struct xe_step_info adls_revids[] = {
>  	[0xC] = { COMMON_GT_MEDIA_STEP(D0), .display = STEP_C0 },
>  };
>  
> +static const struct xe_step_info adls_rpls_revids[] = {
> +	[0x4] = { COMMON_GT_MEDIA_STEP(D0), .display = STEP_D0 },
> +	[0xC] = { COMMON_GT_MEDIA_STEP(D0), .display = STEP_C0 },
> +};
> +
>  static const struct xe_step_info adlp_revids[] = {
>  	[0x0] = { COMMON_GT_MEDIA_STEP(A0), .display = STEP_A0 },
>  	[0x4] = { COMMON_GT_MEDIA_STEP(B0), .display = STEP_B0 },
> @@ -136,6 +141,9 @@ struct xe_step_info xe_step_get(struct xe_device *xe)
>  	} else if (xe->info.platform == XE_ALDERLAKE_N) {
>  		revids = adln_revids;
>  		size = ARRAY_SIZE(adln_revids);
> +	} else if (xe->info.subplatform == XE_SUBPLATFORM_ADLS_RPLS) {
> +		revids = adls_rpls_revids;
> +		size = ARRAY_SIZE(adls_rpls_revids);
>  	} else if (xe->info.subplatform == XE_SUBPLATFORM_ADLP_RPLU) {
>  		revids = adlp_rpl_revids;
>  		size = ARRAY_SIZE(adlp_rpl_revids);
> -- 
> 2.25.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation


More information about the Intel-xe mailing list