[Intel-xe] [PATCH 0/2] Update Xe uAPI in a minimally invasive way

Christopher Snowhill kode54 at gmail.com
Wed May 24 03:31:29 UTC 2023


This series takes off from mlankhorst's attempt to do the same, except
instead, it tries to be as minimally invasive to the original uAPI as
possible, by only inserting padding where appropriate to ensure all
32-bit members are 32-bit aligned, and all 64-bit members are 64-bit
aligned. This should have zero effect on 64-bit hosts versus 64-bit
userspace, so existing native software will operate the same with or
without the update. The only real change is 32-bit compat support for
multilib userspace, which was previously broken.

Also introduces field validation against all of the padding and
reserved fields, which must be zero, in a separate commit.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Signed-off-by: Christopher Snowhill <kode54 at gmail.com>

Christopher Snowhill (2):
  drm/xe: Add explicit padding to uAPI definition
  drm/xe: Validate uAPI padding and reserved fields

 drivers/gpu/drm/xe/xe_bo.c              |  6 +++--
 drivers/gpu/drm/xe/xe_engine.c          | 19 +++++++++++---
 drivers/gpu/drm/xe/xe_exec.c            |  4 ++-
 drivers/gpu/drm/xe/xe_mmio.c            |  3 ++-
 drivers/gpu/drm/xe/xe_query.c           |  3 ++-
 drivers/gpu/drm/xe/xe_sync.c            |  4 ++-
 drivers/gpu/drm/xe/xe_vm.c              | 22 +++++++++++++---
 drivers/gpu/drm/xe/xe_vm_madvise.c      |  4 ++-
 drivers/gpu/drm/xe/xe_wait_user_fence.c |  3 ++-
 include/uapi/drm/xe_drm.h               | 34 ++++++++++++++++++++++++-
 10 files changed, 86 insertions(+), 16 deletions(-)

-- 
2.40.1



More information about the Intel-xe mailing list