[Intel-xe] [PATCH v10 3/9] drm/xe: drop xe_device_mem_access_get() from guc_ct_send

Rodrigo Vivi rodrigo.vivi at kernel.org
Wed May 24 19:33:58 UTC 2023


On Wed, May 24, 2023 at 06:56:55PM +0100, Matthew Auld wrote:
> The callers should already be holding the mem_access reference, before
> calling into this.
> 
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_ct.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
> index 9dc906f2651a..874323c382b3 100644
> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
> @@ -605,14 +605,10 @@ static int guc_ct_send(struct xe_guc_ct *ct, const u32 *action, u32 len,
>  
>  	XE_BUG_ON(g2h_len && g2h_fence);
>  
> -	xe_device_mem_access_get(ct_to_xe(ct));
> -
>  	mutex_lock(&ct->lock);
>  	ret = guc_ct_send_locked(ct, action, len, g2h_len, num_g2h, g2h_fence);
>  	mutex_unlock(&ct->lock);
>  
> -	xe_device_mem_access_put(ct_to_xe(ct));
> -
>  	return ret;
>  }
>  
> -- 
> 2.40.1
> 


More information about the Intel-xe mailing list