[Intel-xe] [PATCH v2 0/2] Update Xe uAPI in a minimally invasive way

Christopher Snowhill kode54 at gmail.com
Thu May 25 13:39:53 UTC 2023


I've filed a draft MR against intel-compute, but media doesn't have any 
code using the header, which hasn't been added to their repository yet 
anyway. I can file a MR that adds it to the uapi headers folder, though.

On 5/25/23 06:24, Souza, Jose wrote:
> Hi
>
> Planning to push this today,
> Christopher already have sent the Mesa MR and IGT patch series.
> It should not break 64 bits ABI but would be good to update intel-compute and media as well.
>
> On Wed, 2023-05-24 at 18:56 -0700, Christopher Snowhill wrote:
>> This series takes off from mlankhorst's attempt to do the same, except
>> instead, it tries to be as minimally invasive to the original uAPI as
>> possible, by only inserting padding where appropriate to ensure all
>> 32-bit members are 32-bit aligned, and all 64-bit members are 64-bit
>> aligned. This should have zero effect on 64-bit hosts versus 64-bit
>> userspace, so existing native software will operate the same with or
>> without the update. The only real change is 32-bit compat support for
>> multilib userspace, which was previously broken.
>>
>> Also introduces field validation against all of the padding and
>> reserved fields, which must be zero, in a separate commit.
>>
>> v2:
>>    Removed extensions checks where there were none originally. (José)
>>    Moved extraneous parentheses to the correct places. (Lucas)
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> Signed-off-by: Christopher Snowhill <kode54 at gmail.com>
>>
>> Christopher Snowhill (2):
>>    drm/xe: Add explicit padding to uAPI definition
>>    drm/xe: Validate uAPI padding and reserved fields
>>
>>   drivers/gpu/drm/xe/xe_bo.c              |  6 +++--
>>   drivers/gpu/drm/xe/xe_engine.c          | 18 ++++++++++---
>>   drivers/gpu/drm/xe/xe_exec.c            |  4 ++-
>>   drivers/gpu/drm/xe/xe_mmio.c            |  3 ++-
>>   drivers/gpu/drm/xe/xe_query.c           |  3 ++-
>>   drivers/gpu/drm/xe/xe_sync.c            |  4 ++-
>>   drivers/gpu/drm/xe/xe_vm.c              | 22 +++++++++++++---
>>   drivers/gpu/drm/xe/xe_vm_madvise.c      |  4 ++-
>>   drivers/gpu/drm/xe/xe_wait_user_fence.c |  3 ++-
>>   include/uapi/drm/xe_drm.h               | 34 ++++++++++++++++++++++++-
>>   10 files changed, 85 insertions(+), 16 deletions(-)
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x8D6C98479F4ADE71.asc
Type: application/pgp-keys
Size: 10398 bytes
Desc: OpenPGP public key
URL: <https://lists.freedesktop.org/archives/intel-xe/attachments/20230525/ac7f5501/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/intel-xe/attachments/20230525/ac7f5501/attachment-0001.sig>


More information about the Intel-xe mailing list