[Intel-xe] [PATCH v4 03/21] drm/xe/rtp: Replace XE_WARN_ON

Matt Roper matthew.d.roper at intel.com
Thu May 25 22:18:11 UTC 2023


On Thu, May 25, 2023 at 02:33:49PM -0700, Lucas De Marchi wrote:
> Now that rule_matches() always has an xe pointer, replace the XE_WARN_ON
> with the more appropriate drm_warn().
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_rtp.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_rtp.c b/drivers/gpu/drm/xe/xe_rtp.c
> index 5be25fe0e8e4..5dcdfe45f0cb 100644
> --- a/drivers/gpu/drm/xe/xe_rtp.c
> +++ b/drivers/gpu/drm/xe/xe_rtp.c
> @@ -84,7 +84,9 @@ static bool rule_matches(const struct xe_device *xe,
>  			match = r->match_func(gt, hwe);
>  			break;
>  		default:
> -			XE_WARN_ON(r->match_type);
> +			drm_warn(&xe->drm, "Invalid RTP match %u\n",
> +				 r->match_type);
> +			match = false;
>  		}
>  
>  		if (!match)
> -- 
> 2.40.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation


More information about the Intel-xe mailing list