[Intel-xe] [PATCH 1/2] fixup! drm/xe/debugfs: Dump register save-restore tables

[Gustavo Sousa]

Quoting Lucas De Marchi (2023-05-26 13:34:59-03:00)
>On Thu, May 25, 2023 at 09:42:34PM -0300, Gustavo Sousa wrote:
>>Remove repeated header inclusion.
>>
>>Signed-off-by: Gustavo Sousa <gustavo.sousa at intel.com>
>
>Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Thanks! Pushed.

>
>do you know a way to check the header includes that we could add in
>our CI Hooks
>(https://gitlab.freedesktop.org/drm/xe/ci/-/tree/main/hooks)?

Well, if we just want to check for ordering and making sure we do not
duplicate includes, I guess a shell or Python script using regular
expressions would do it. We could even have checks for grouping and for
checking style (<> vs "").

That said, for more advanced stuff, I wonder if there are specialized
tools out there that would also do them. For example, sometimes we have
some files using stuff defined by headers that they do not include,
which, IMHO, is not a good practice in general.

--
Gustavo Sousa