[Intel-xe] [PATCH v2 0/5] drm/xe: uAPI cleanup

[Francois Dugast]

On Wed, May 31, 2023 at 09:23:45AM -0700, Lucas De Marchi wrote:
> +Oded
> 
> On Wed, May 31, 2023 at 03:23:33PM +0000, Francois Dugast wrote:
> > This series addresses some feedback on xe_drm.h provided here:
> > https://lists.freedesktop.org/archives/intel-xe/2023-May/004704.html
> > 
> > It is based on xe-rev1-2023-05-02, not on drm-xe-next, so it will
> > likely break CI.
> 
> As I said on the previous reply, this is not going to fly. Now we have a
> patch series against xe-rev1-2023-05-02, pushed as xe-rev2 branch with
> *no recorded reviews*, doing things that already conflict with other
> fixes that landed in drm-xe-next. Examples: the 32b compat for uapi,
> the mmio refactor, the oob WAs, the probe refactor, etc etc.
> 
> Also, there are other fixes queued as fixups, which is still the process
> being used in drm-xe-next. It's also where CI is running. Due to display
> being moved up in the branch it's basically the only sane thing to do.
> 
> I think we need we are shooting ourselves on the foot and this review
> process needs to be fixed / agreed upon before we create a mess out of
> it.
> 
> Lucas De Marchi

Yes I understand the concern. The intention is to address Oded's feedback on the
revision that was reviewed, so that the next review iteration is manageable and
not based on a moving target, which could lead to and endless effort.

Maybe I created confusion by sharing on the mailing list but at this stage the
idea is not to get this series merged, only to get Oded's validation that it
fixes the issues that he reported. Yes this means more work will be required to
rebase and create fixups later for drm-xe-next but it seems acceptable for the
work that has been done so far.

Do you see a better way that would still satisfy the "not moving target" goal?

Thanks,
Francois

> 
> > 
> > v2: fix ordering of defines and fields in uAPI (Lucas De Marchi)
> > 
> > Francois Dugast (5):
> >  drm/xe: Use SPDX-License-Identifier instead of license text
> >  drm/xe: Group engine related structs
> >  drm/xe: Move defines before relevant fields
> >  drm/xe: Document usage of struct drm_xe_device_query
> >  drm/xe: Fix some formatting issues in uAPI
> > 
> > include/uapi/drm/xe_drm.h | 171 ++++++++++++++++++++------------------
> > 1 file changed, 90 insertions(+), 81 deletions(-)
> > 
> > -- 
> > 2.34.1
> >