[Intel-xe] ✗ CI.checkpatch: warning for drm/xe/pvc: Enable fixed CCS mode (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Nov 2 00:23:49 UTC 2023


== Series Details ==

Series: drm/xe/pvc: Enable fixed CCS mode (rev2)
URL   : https://patchwork.freedesktop.org/series/125148/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 9c6d43b58b9ce9a15b7404b4f4ff653927e60c7f
Author: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
Date:   Wed Nov 1 16:57:49 2023 -0700

    drm/xe: Prevent exec_queues creation on diabled CCS engines
    
    Ensure no exec_queues are opened when changing CCS mode.
    Allow exec_queue creation only with enabled CCS engines.
    
    Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
+ /mt/dim checkpatch ff616f1d0e92e64af239b351437421eb78922b8c drm-intel
1004e6569 drm/xe: Enable Fixed CCS mode setting
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:48: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cslice' may be better as '(cslice)' to avoid precedence issues
#48: FILE: drivers/gpu/drm/xe/regs/xe_gt_regs.h:404:
+#define   CCS_MODE_CSLICE(cslice, ccs) \
+	(ccs << (cslice * CCS_MODE_CSLICE_WIDTH))

-:48: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ccs' may be better as '(ccs)' to avoid precedence issues
#48: FILE: drivers/gpu/drm/xe/regs/xe_gt_regs.h:404:
+#define   CCS_MODE_CSLICE(cslice, ccs) \
+	(ccs << (cslice * CCS_MODE_CSLICE_WIDTH))

-:155: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gt' may be better as '(gt)' to avoid precedence issues
#155: FILE: drivers/gpu/drm/xe/xe_gt.h:20:
+#define CCS_MASK(gt) ((gt->info.engine_mask & XE_HW_ENGINE_CCS_MASK) >> XE_HW_ENGINE_CCS0)

-:161: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#161: 
new file mode 100644

total: 0 errors, 1 warnings, 3 checks, 363 lines checked
9c6d43b58 drm/xe: Prevent exec_queues creation on diabled CCS engines
-:4: WARNING:TYPO_SPELLING: 'diabled' may be misspelled - perhaps 'disabled'?
#4: 
Subject: [PATCH] drm/xe: Prevent exec_queues creation on diabled CCS engines
                                                         ^^^^^^^

total: 0 errors, 1 warnings, 0 checks, 117 lines checked




More information about the Intel-xe mailing list