[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Encapsulate all the module parameters (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Nov 2 20:10:41 UTC 2023


== Series Details ==

Series: drm/xe: Encapsulate all the module parameters (rev2)
URL   : https://patchwork.freedesktop.org/series/124995/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit fc20733f3780a32fc991ffbb3d516ba8fc81a3c5
Author: Bommithi Sakeena <bommithi.sakeena at intel.com>
Date:   Thu Nov 2 19:51:02 2023 +0000

    drm/xe: Encapsulate all the module parameters
    
    Encapsulate all the module paramters in one single global struct
    variable. This also removes the extra xe_module.h from includes.
    
    v2: naming consistency as suggested by Jani and Lucas
    
    Cc: Jani Nikula <jani.nikula at linux.intel.com>
    Cc: Lucas De Marchi <lucas.demarchi at intel.com>
    Signed-off-by: Bommithi Sakeena <bommithi.sakeena at intel.com>
+ /mt/dim checkpatch 58dfdb8dc78e5668f9891c798ec3191863c1e0d2 drm-intel
fc20733f3 drm/xe: Encapsulate all the module parameters
-:6: WARNING:TYPO_SPELLING: 'paramters' may be misspelled - perhaps 'parameters'?
#6: 
Encapsulate all the module paramters in one single global struct
                           ^^^^^^^^^

-:156: ERROR:CODE_INDENT: code indent should use tabs where possible
#156: FILE: drivers/gpu/drm/xe/xe_module.h:13:
+        bool force_execlist;$

-:156: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#156: FILE: drivers/gpu/drm/xe/xe_module.h:13:
+        bool force_execlist;$

-:157: ERROR:CODE_INDENT: code indent should use tabs where possible
#157: FILE: drivers/gpu/drm/xe/xe_module.h:14:
+        bool enable_display;$

-:157: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#157: FILE: drivers/gpu/drm/xe/xe_module.h:14:
+        bool enable_display;$

-:158: ERROR:CODE_INDENT: code indent should use tabs where possible
#158: FILE: drivers/gpu/drm/xe/xe_module.h:15:
+        u32 force_vram_bar_size;$

-:158: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: drivers/gpu/drm/xe/xe_module.h:15:
+        u32 force_vram_bar_size;$

-:159: ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: drivers/gpu/drm/xe/xe_module.h:16:
+        int guc_log_level;$

-:159: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: drivers/gpu/drm/xe/xe_module.h:16:
+        int guc_log_level;$

-:160: ERROR:CODE_INDENT: code indent should use tabs where possible
#160: FILE: drivers/gpu/drm/xe/xe_module.h:17:
+        char *guc_firmware_path;$

-:160: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: drivers/gpu/drm/xe/xe_module.h:17:
+        char *guc_firmware_path;$

-:161: ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: drivers/gpu/drm/xe/xe_module.h:18:
+        char *huc_firmware_path;$

-:161: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: drivers/gpu/drm/xe/xe_module.h:18:
+        char *huc_firmware_path;$

-:162: ERROR:CODE_INDENT: code indent should use tabs where possible
#162: FILE: drivers/gpu/drm/xe/xe_module.h:19:
+        char *force_probe;$

-:162: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#162: FILE: drivers/gpu/drm/xe/xe_module.h:19:
+        char *force_probe;$

-:164: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#164: FILE: drivers/gpu/drm/xe/xe_module.h:21:
+};
+extern struct xe_modparam xe_modparam;

total: 7 errors, 8 warnings, 1 checks, 158 lines checked




More information about the Intel-xe mailing list