[Intel-xe] [PATCH] drm/xe/xelpmp: Add Wa_16021867713

Gustavo Sousa gustavo.sousa at intel.com
Tue Nov 7 13:19:43 UTC 2023


Quoting Matt Roper (2023-11-06 18:41:40-03:00)
>On Mon, Nov 06, 2023 at 06:06:57PM -0300, Gustavo Sousa wrote:
>> This workaround applies to all steppings of Xe_LPM+. Implement the KMD
>> part.
>> 
>> Signed-off-by: Gustavo Sousa <gustavo.sousa at intel.com>
>
>Looks like this is trending to also be needed on LNL's Xe2_LPM as well,
>although that isn't quite finalized yet.  We can come back and deal with
>that if/when it becomes final.
>
>Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

Pushed to drm-xe-next. Thanks for the review!

--
Gustavo Sousa

>
>> ---
>>  drivers/gpu/drm/xe/regs/xe_engine_regs.h | 3 +++
>>  drivers/gpu/drm/xe/xe_wa.c               | 6 ++++++
>>  2 files changed, 9 insertions(+)
>> 
>> diff --git a/drivers/gpu/drm/xe/regs/xe_engine_regs.h b/drivers/gpu/drm/xe/regs/xe_engine_regs.h
>> index 35dd4837dd75..b57dec17eb2d 100644
>> --- a/drivers/gpu/drm/xe/regs/xe_engine_regs.h
>> +++ b/drivers/gpu/drm/xe/regs/xe_engine_regs.h
>> @@ -118,4 +118,7 @@
>>  #define VDBOX_CGCTL3F18(base)                        XE_REG((base) + 0x3f18)
>>  #define   ALNUNIT_CLKGATE_DIS                        REG_BIT(13)
>>  
>> +#define VDBOX_CGCTL3F1C(base)                        XE_REG((base) + 0x3f1c)
>> +#define   MFXPIPE_CLKGATE_DIS                        REG_BIT(3)
>> +
>>  #endif
>> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
>> index 2f1782db267b..614e114a5342 100644
>> --- a/drivers/gpu/drm/xe/xe_wa.c
>> +++ b/drivers/gpu/drm/xe/xe_wa.c
>> @@ -248,6 +248,12 @@ static const struct xe_rtp_entry_sr gt_was[] = {
>>  
>>          /* Xe_LPM+ */
>>  
>> +        { XE_RTP_NAME("16021867713"),
>> +          XE_RTP_RULES(MEDIA_VERSION(1300),
>> +                       ENGINE_CLASS(VIDEO_DECODE)),
>> +          XE_RTP_ACTIONS(SET(VDBOX_CGCTL3F1C(0), MFXPIPE_CLKGATE_DIS)),
>> +          XE_RTP_ENTRY_FLAG(FOREACH_ENGINE),
>> +        },
>>          { XE_RTP_NAME("22016670082"),
>>            XE_RTP_RULES(MEDIA_VERSION(1300)),
>>            XE_RTP_ACTIONS(SET(XELPMP_SQCNT1, ENFORCE_RAR))
>> -- 
>> 2.42.0
>> 
>
>-- 
>Matt Roper
>Graphics Software Engineer
>Linux GPU Platform Enablement
>Intel Corporation


More information about the Intel-xe mailing list