[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Probe tweaks and reordering (part 1)

Patchwork patchwork at emeril.freedesktop.org
Wed Nov 8 00:38:44 UTC 2023


== Series Details ==

Series: drm/xe: Probe tweaks and reordering (part 1)
URL   : https://patchwork.freedesktop.org/series/126105/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit e630dfcc676ebc3cff540aa0bf99cc4b114ed57e
Author: Michał Winiarski <michal.winiarski at intel.com>
Date:   Wed Nov 8 01:33:44 2023 +0100

    drm/xe: Don't "peek" into GMD_ID
    
    Now that MMIO init got moved to device early, we can use regular
    xe_mmio_read helpers to get to GMD_ID register.
    
    Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
+ /mt/dim checkpatch 3b0bded07ef9f00e6120c6856e86e3faf897191f drm-intel
a9124875a drm/xe: Remove shutdown
f0552fe23 drm/xe: Skip calling drm_dev_put on probe error
2aeedfd89 drm/xe: Use managed pci_enable_device
1a40cd86c drm/xe/irq: Don't call pci_free_irq_vectors
310d20fcd drm/xe/mmio: Move memory training check to probe vram
ef0e47638 drm/xe: Move xe_set_dma_info outside of MMIO setup
4276ac802 drm/xe: Move xe_mmio_probe_tiles outside of MMIO setup
e9f5414c2 drm/xe: Split xe_info_init
fc75a5373 drm/xe: Introduce xe_tile_init_early and use at earlier point in probe
8d82361ad drm/xe: Map the entire BAR0 and hold onto the initial mapping
634a39d28 drm/xe/device: Introduce xe_device_probe_early
-:94: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'xe__' - possible side-effects?
#94: FILE: drivers/gpu/drm/xe/xe_device.h:126:
+#define for_each_remote_tile(tile__, xe__, id__) \
+	for ((id__) = 1; (id__) < (xe__)->info.tile_count; (id__)++) \
+		for_each_if((tile__) = &(xe__)->tiles[(id__)])

-:94: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible side-effects?
#94: FILE: drivers/gpu/drm/xe/xe_device.h:126:
+#define for_each_remote_tile(tile__, xe__, id__) \
+	for ((id__) = 1; (id__) < (xe__)->info.tile_count; (id__)++) \
+		for_each_if((tile__) = &(xe__)->tiles[(id__)])

total: 0 errors, 0 warnings, 2 checks, 171 lines checked
e630dfcc6 drm/xe: Don't "peek" into GMD_ID




More information about the Intel-xe mailing list