[Intel-xe] [PATCH 01/12] drm/xe: Remove shutdown

Michał Winiarski michal.winiarski at intel.com
Wed Nov 8 18:22:06 UTC 2023


On Wed, Nov 08, 2023 at 05:38:25PM +0200, Ville Syrjälä wrote:
> On Wed, Nov 08, 2023 at 01:33:33AM +0100, Michał Winiarski wrote:
> > It's not a required callback,
> 
> That doesn't seem right. Display should be turned off, all DMA
> should be stopped, etc. here.

Yeah, I mean from subsystem perspective - the PCI subsystem won't fail
the "register_driver()" if there's no .shutdown().

-Michał

> 
> > and Xe implementation is empty 
> 
> That is certainly true.
> 
> > - remove
> > it.
> > 
> > Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_device.c | 4 ----
> >  drivers/gpu/drm/xe/xe_device.h | 1 -
> >  drivers/gpu/drm/xe/xe_pci.c    | 6 ------
> >  3 files changed, 11 deletions(-)


More information about the Intel-xe mailing list