[Intel-xe] [PATCH 02/12] fixup! drm/xe/guc: Report submission version of GuC firmware

[Daniele Ceraolo Spurio]

On 11/7/2023 3:38 PM, John Harrison wrote:
> On 11/7/2023 15:24, Daniele Ceraolo Spurio wrote:
>> On 11/7/2023 3:07 PM, John Harrison wrote:
>>> On 10/27/2023 15:29, Daniele Ceraolo Spurio wrote:
>>>> Major GuC versions greater than 70 will have the submission version in
>>>> the herader irrespective of their minor version number.
>>>>
>>>> Signed-off-by: Daniele Ceraolo Spurio 
>>>> <daniele.ceraolospurio at intel.com>
>>>> Cc: Matthew Brost <matthew.brost at intel.com>
>>>> Cc: John Harrison <John.C.Harrison at Intel.com>
>>>> Reviewed-by: Matthew Brost <matthew.brost at intel.com>
>>>> ---
>>>>   drivers/gpu/drm/xe/xe_uc_fw.c | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c 
>>>> b/drivers/gpu/drm/xe/xe_uc_fw.c
>>>> index 3032c4f148d4..91d4a2272ee7 100644
>>>> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
>>>> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
>>>> @@ -278,7 +278,7 @@ static void guc_read_css_info(struct xe_uc_fw 
>>>> *uc_fw, struct uc_css_header *css)
>>>>       xe_gt_assert(gt, uc_fw->type == XE_UC_FW_TYPE_GUC);
>>>>       xe_gt_assert(gt, uc_fw->major_ver_found >= 70);
>>>>   -    if (uc_fw->minor_ver_found >= 6) {
>>>> +    if (uc_fw->major_ver_found > 70 || uc_fw->minor_ver_found >= 6) {
>>> I strongly recommend that we update to a newer version than 70.5.x 
>>> for all platforms and then just drop all this code before Xe goes 
>>> live. There is no need to be carrying this legacy hack in the shiny 
>>> new clean driver!
>>
>> How do you guarantee that the user is running at least 70.6? They 
>> might have an old firmware package. We don't currently fail if the 
>> minor is too low, we just throw a warning, so the driver would still 
>> load but the compatibility would be left unset in that scenario. Or 
>> are you suggesting to just fail the load if GuC < 70.6 ?
> The only publicly supported platforms for Xe right now are LNL and 
> later, aren't they? There is no GuC prior to 70.6 for LNL or later. 
> And anything else is unofficial and for internal testing only.
>
> But yeah, maybe go with >=70.6 or fail (it currently says >=70.0.0 or 
> fail?) to be totally safe.

I went to implement this, but I've realized that the newest GuC FW we 
have pushed for DG1 is 70.5.1, so forcing 70.6 would break DG1 support. 
I think the best option here would be to just pull DG1 support from Xe 
since we're not validating it, instead of pushing a newer GuC for a 
platform that's not fully supported.
TODO list has been updated, but in the meantime I'll stick with this 
patch for the GSC series.

Daniele

>
> John.
>
>>
>> Daniele
>>
>>>
>>> John.
>>>
>>>>           /* v70.6.0 adds CSS header support */
>>>>           guc->submission_state.version.major =
>>>>               FIELD_GET(CSS_SW_VERSION_UC_MAJOR,
>>>
>>
>