[Intel-xe] [6/9] FIXME drm/i915/display: add_dma_resv_fences is i915 only

[Hogander, Jouni]

On Thu, 2023-11-09 at 16:07 +0100, Maarten Lankhorst wrote:
> From: Maarten Lankhorst <dev at lankhorst.se>
> 
> I'm 99% sure that this code is no longer needed on i915, but I'm 100%
> sure it won't be needed for xe.

And it does nothing for Xe -> ifdefs added by this patch are just
optimization to not build this part for Xe.

This isn't blocking any Xe work so if you think this isn't needed for
i915 I think you should send the patch to
intel-gfx at lists.freedesktop.org. Do the review and CI testing there and
then backport.

BR,

Jouni Högander

> 
> Signed-off-by: Maarten Lankhorst <dev at lankhorst.se>
> ---
>  drivers/gpu/drm/i915/display/intel_atomic_plane.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> index ef553270c0796..a5ee4af25836f 100644
> --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> @@ -1021,9 +1021,10 @@ int intel_plane_check_src_coordinates(struct
> intel_plane_state *plane_state)
>  static int add_dma_resv_fences(struct dma_resv *resv,
>                                struct drm_plane_state
> *new_plane_state)
>  {
> +       int ret = 0;
> +#ifdef I915
>         struct dma_fence *fence = dma_fence_get(new_plane_state-
> >fence);
>         struct dma_fence *new;
> -       int ret;
>  
>         ret = dma_resv_get_singleton(resv, dma_resv_usage_rw(false),
> &new);
>         if (ret)
> @@ -1050,6 +1051,7 @@ static int add_dma_resv_fences(struct dma_resv
> *resv,
>  
>  error:
>         dma_fence_put(fence);
> +#endif
>         return ret;
>  }
>