[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Probe tweaks and reordering

[Patchwork]

== Series Details ==

Series: drm/xe: Probe tweaks and reordering
URL   : https://patchwork.freedesktop.org/series/126392/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c99e208987a9e361f77f69505acc6d40eaa6381c
Author: Michał Winiarski <michal.winiarski at intel.com>
Date:   Tue Nov 14 12:44:05 2023 +0100

    drm/xe: Initialize GuC earlier during probe
    
    SR-IOV VF has limited access to MMIO registers. Fortunately, it is able
    to access a curated subset that is needed to initialize the driver by
    communicating with SR-IOV PF using GuC CT.
    Initialize GuC earlier in order to keep the unified probe ordering
    between VF and PF modes.
    
    Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
+ /mt/dim checkpatch 7dc3dda9b2df5a5c8949532f254a0689de70f093 drm-intel
733455e30 drm/xe: Skip calling drm_dev_put on probe error
23fc9ce27 drm/xe: Use managed pci_enable_device
c8a0fa871 drm/xe/irq: Don't call pci_free_irq_vectors
03f0f994f drm/xe: Move xe_set_dma_info outside of MMIO setup
ebae0272e drm/xe: Move xe_mmio_probe_tiles outside of MMIO setup
86146c9ea drm/xe: Split xe_info_init
8fbd952db drm/xe: Introduce xe_tile_init_early and use at earlier point in probe
b4bec6061 drm/xe: Map the entire BAR0 and hold onto the initial mapping
fa91b0d33 drm/xe/device: Introduce xe_device_probe_early
-:74: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'xe__' - possible side-effects?
#74: FILE: drivers/gpu/drm/xe/xe_device.h:127:
+#define for_each_remote_tile(tile__, xe__, id__) \
+	for ((id__) = 1; (id__) < (xe__)->info.tile_count; (id__)++) \
+		for_each_if((tile__) = &(xe__)->tiles[(id__)])

-:74: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible side-effects?
#74: FILE: drivers/gpu/drm/xe/xe_device.h:127:
+#define for_each_remote_tile(tile__, xe__, id__) \
+	for ((id__) = 1; (id__) < (xe__)->info.tile_count; (id__)++) \
+		for_each_if((tile__) = &(xe__)->tiles[(id__)])

-:152: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#152: FILE: drivers/gpu/drm/xe/xe_pci.c:541:
+static int xe_info_init_early(struct xe_device *xe,
 			       const struct xe_device_desc *desc,

total: 0 errors, 0 warnings, 3 checks, 155 lines checked
17f87dba9 drm/xe: Don't "peek" into GMD_ID
160c50870 drm/xe: Move system memory management init to earlier point in probe
e7d133fb0 drm/xe: Move force_wake init to earlier point in probe
3ee9c9493 drm/xe: Reorder GGTT init to earlier point in probe
e070aadbe drm/xe/uc: Split xe_uc_fw_init
8731b1e6e drm/xe/uc: Store firmware binary in system-memory backed BO
7e7d12180 drm/xe/uc: Extract xe_uc_sanitize_reset
31cd9d759 drm/xe/guc: Split GuC params used for "hwconfig" and "post-hwconfig"
22b0dd537 drm/xe/guc: Allocate GuC data structures in system memory for initial load
2aae93d9e drm/xe/guc: Move GuC power control init to "post-hwconfig"
c99e20898 drm/xe: Initialize GuC earlier during probe