[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Probe tweaks and reordering (rev2)

[Patchwork]

== Series Details ==

Series: drm/xe: Probe tweaks and reordering (rev2)
URL   : https://patchwork.freedesktop.org/series/126392/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 32fa0441b75e63bbdbc16332c408cda1ff6e2766
Author: Michał Winiarski <michal.winiarski at intel.com>
Date:   Tue Nov 14 14:02:31 2023 +0100

    drm/xe: Initialize GuC earlier during probe
    
    SR-IOV VF has limited access to MMIO registers. Fortunately, it is able
    to access a curated subset that is needed to initialize the driver by
    communicating with SR-IOV PF using GuC CT.
    Initialize GuC earlier in order to keep the unified probe ordering
    between VF and PF modes.
    
    Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
+ /mt/dim checkpatch 7dc3dda9b2df5a5c8949532f254a0689de70f093 drm-intel
b15910a5d drm/xe: Skip calling drm_dev_put on probe error
d5ac5bea2 drm/xe: Use managed pci_enable_device
a48563b38 drm/xe/irq: Don't call pci_free_irq_vectors
bb09a122c drm/xe: Move xe_set_dma_info outside of MMIO setup
95648fa68 drm/xe: Move xe_mmio_probe_tiles outside of MMIO setup
b082b038a drm/xe: Split xe_info_init
5e888d7e0 drm/xe: Introduce xe_tile_init_early and use at earlier point in probe
cb26847c8 drm/xe: Map the entire BAR0 and hold onto the initial mapping
efea961ab drm/xe/device: Introduce xe_device_probe_early
-:74: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'xe__' - possible side-effects?
#74: FILE: drivers/gpu/drm/xe/xe_device.h:127:
+#define for_each_remote_tile(tile__, xe__, id__) \
+	for ((id__) = 1; (id__) < (xe__)->info.tile_count; (id__)++) \
+		for_each_if((tile__) = &(xe__)->tiles[(id__)])

-:74: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible side-effects?
#74: FILE: drivers/gpu/drm/xe/xe_device.h:127:
+#define for_each_remote_tile(tile__, xe__, id__) \
+	for ((id__) = 1; (id__) < (xe__)->info.tile_count; (id__)++) \
+		for_each_if((tile__) = &(xe__)->tiles[(id__)])

-:152: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#152: FILE: drivers/gpu/drm/xe/xe_pci.c:541:
+static int xe_info_init_early(struct xe_device *xe,
 			       const struct xe_device_desc *desc,

total: 0 errors, 0 warnings, 3 checks, 155 lines checked
19bdcd70f drm/xe: Don't "peek" into GMD_ID
69f783f8d drm/xe: Move system memory management init to earlier point in probe
ee8f7ec79 drm/xe: Move force_wake init to earlier point in probe
7e0121fd7 drm/xe: Reorder GGTT init to earlier point in probe
030166acc drm/xe/uc: Split xe_uc_fw_init
8fb404848 drm/xe/uc: Store firmware binary in system-memory backed BO
cf405071c drm/xe/uc: Extract xe_uc_sanitize_reset
08f0712e8 drm/xe/guc: Split GuC params used for "hwconfig" and "post-hwconfig"
0f61dd5ff drm/xe/guc: Allocate GuC data structures in system memory for initial load
7d3fbb0e1 drm/xe/guc: Move GuC power control init to "post-hwconfig"
32fa0441b drm/xe: Initialize GuC earlier during probe