[Intel-xe] [PATCH 2/4] drm/xe/guc: Copy response data from proper registers

Matthew Brost matthew.brost at intel.com
Wed Nov 15 09:04:40 UTC 2023


On Wed, Nov 15, 2023 at 12:37:46PM +0100, Michal Wajdeczko wrote:
> While copying GuC response from the scratch registers to the buffer,
> formula to identify next scratch register is broken. Fix it.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

Reviewed-by: Matthew Brost <matthew.brost at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
> index 84f0b5488783..ddbe64eb0f3b 100644
> --- a/drivers/gpu/drm/xe/xe_guc.c
> +++ b/drivers/gpu/drm/xe/xe_guc.c
> @@ -715,7 +715,7 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request,
>  		response_buf[0] = header;
>  
>  		for (i = 1; i < VF_SW_FLAG_COUNT; i++) {
> -			reply_reg.addr += i * sizeof(u32);
> +			reply_reg.addr += sizeof(u32);
>  			response_buf[i] = xe_mmio_read32(gt, reply_reg);
>  		}
>  	}
> -- 
> 2.25.1
> 


More information about the Intel-xe mailing list