[Intel-xe] [PATCH] drm/xe/pmu: fix config counters in pmu

Riana Tauro riana.tauro at intel.com
Fri Nov 17 14:37:33 UTC 2023


Hi Aravind

On 11/17/2023 4:04 PM, Aravind Iddamsetty wrote:
> 
> On 17/11/23 15:41, Aravind Iddamsetty wrote:
>> On 17/11/23 14:52, Riana Tauro wrote:
>>> Interrupt pmu event was dropped in a previous patch
>>> and the configs for the rest of the events were changed
>>> in uapi header.
>>>
>>> Change the configs in pmu file too.
>> Hi Riana,
> 
> actually i was thinking this better be a fixup! patch to this commit "drm/xe/pmu: Drop interrupt pmu event"Sure will send out a fixup patch

Thanks
Riana
> 
> Thanks,
> Aravind.
>>
>> Thanks for catching the bug.
>>
>> Reviewed-by: Aravind Iddamsetty <aravind.iddamsetty at linux.intel.com>
>>
>> Regards,
>> Aravind.
>>> Cc: Aravind Iddamsetty <aravind.iddamsetty at linux.intel.com>
>>> Signed-off-by: Riana Tauro <riana.tauro at intel.com>
>>> ---
>>>   drivers/gpu/drm/xe/xe_pmu.c | 8 ++++----
>>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/xe/xe_pmu.c b/drivers/gpu/drm/xe/xe_pmu.c
>>> index 318bbc9c1c9b..c63b7f2fd8a8 100644
>>> --- a/drivers/gpu/drm/xe/xe_pmu.c
>>> +++ b/drivers/gpu/drm/xe/xe_pmu.c
>>> @@ -353,10 +353,10 @@ create_event_attributes(struct xe_pmu *pmu)
>>>   		const char *unit;
>>>   		bool global;
>>>   	} events[] = {
>>> -		__event(1, "render-group-busy", "ns"),
>>> -		__event(2, "copy-group-busy", "ns"),
>>> -		__event(3, "media-group-busy", "ns"),
>>> -		__event(4, "any-engine-group-busy", "ns"),
>>> +		__event(0, "render-group-busy", "ns"),
>>> +		__event(1, "copy-group-busy", "ns"),
>>> +		__event(2, "media-group-busy", "ns"),
>>> +		__event(3, "any-engine-group-busy", "ns"),
>>>   	};
>>>   
>>>   	struct perf_pmu_events_attr *pmu_attr = NULL, *pmu_iter;


More information about the Intel-xe mailing list