[Intel-xe] [PATCH 2/2] fixup! drm/xe/display: Create a dummy version for vga decode

Gustavo Sousa gustavo.sousa at intel.com
Fri Nov 17 18:53:28 UTC 2023


Quoting Lucas De Marchi (2023-11-17 14:56:24-03:00)
>Fix build with W=1:
>
>          CC [M]  drivers/gpu/drm/xe/display/intel_fbdev_fb.o
>        ../drivers/gpu/drm/xe/display/xe_display_misc.c:10:14: error: no previous prototype for ‘intel_gmch_vga_set_decode’ [-Werror=missing-prototypes]
>           10 | unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
>              |              ^~~~~~~~~~~~~~~~~~~~~~~~~
>        cc1: all warnings being treated as errors
>
>Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>---
> drivers/gpu/drm/xe/display/xe_display_misc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/display/xe_display_misc.c b/drivers/gpu/drm/xe/display/xe_display_misc.c
>index 81ff97e704ea..242c2ef4ca93 100644
>--- a/drivers/gpu/drm/xe/display/xe_display_misc.c
>+++ b/drivers/gpu/drm/xe/display/xe_display_misc.c
>@@ -7,6 +7,8 @@
> 
> struct pci_dev;
> 
>+unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode);
>+

Not pretty, but gets the job done.

Reviewed-by: Gustavo Sousa <gustavo.sousa at intel.com>

> unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
> {
>         /* ToDo: Implement the actual handling of vga decode */
>-- 
>2.40.1
>


More information about the Intel-xe mailing list