[Intel-xe] ✓ CI.checkpatch: success for drm/xe/guc: Use FAST_REQUEST for non-blocking H2G messages
Patchwork
patchwork at emeril.freedesktop.org
Fri Nov 17 21:39:46 UTC 2023
== Series Details ==
Series: drm/xe/guc: Use FAST_REQUEST for non-blocking H2G messages
URL : https://patchwork.freedesktop.org/series/126495/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63c2b6b160bca2df6efc7bc4cea6f442097d7854
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit fc9e159627e18613770a42907146d7d651c068c2
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Date: Wed Nov 15 15:40:43 2023 -0800
drm/xe/guc: Use FAST_REQUEST for non-blocking H2G messages
We're currently sending non-blocking H2G messages using the EVENT type,
which suppresses all CTB protocol replies from the GuC, including the
failure cases. This might cause errors to slip through and manifest as
unexpected behavior (e.g. a context state might not be what the driver
thinks it is because the state change command was silently rejected by
the GuC). To avoid this kind of problems, we can use the FAST_REQUEST
type instead, which suppresses the reply only on success; this way we
still get the advantage of not having to wait for an ack from the GuC
(i.e. the H2G is still non-blocking) while still detecting errors.
Since we don't track the non-blocking messages, we don't exactly know
which one of them failed and therefore can't attempt to recover and need
to escalate to GT reset instead.
Note that FAST_REQUEST failures are NOT expected and are usually a sign
that the H2G was either malformed or requested an illegal operation.
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Cc: John Harrison <John.C.Harrison at Intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
Reviewed-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch 3b8183b7efad3d97ab6cf401f3fc0d24b30b6d3d drm-intel
fc9e15962 drm/xe/guc: Use FAST_REQUEST for non-blocking H2G messages
More information about the Intel-xe
mailing list